ChrisSamo632 commented on a change in pull request #5193:
URL: https://github.com/apache/nifi/pull/5193#discussion_r676404004
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceImpl.java
##########
@@ -375,44 +383,143 @@ private int handleSearchCount(Object raw) {
}
@Override
- public SearchResponse search(String query, String index, String type) {
- Response response = runQuery("_search", query, index, type);
- Map<String, Object> parsed = parseResponse(response);
+ public SearchResponse search(String query, String index, String type,
Map<String, String> requestParameters) {
+ try {
+ final Response response = runQuery("_search", query, index, type,
requestParameters);
+ return buildSearchResponse(response);
Review comment:
Makes sense to return the Elasticsearch warnings in the SearchResponse I
think, good shout - I'll look at how much of a change that is and either
include it or raise a separate Jira ticket (then probably the PR to match)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
