[
https://issues.apache.org/jira/browse/MINIFICPP-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ferenc Gerlits updated MINIFICPP-1600:
--------------------------------------
Description:
There are at least two ways to create a temporary directory in tests (method(s)
in TestController and a helper in TestUtils.h). Moreover these require a
modifiable buffer which makes them cumbersome to use (we introduce a single-use
format variable most of the time). We should change all directory creation to
use a function taking 'const char*' or 'const char(&)[N]'
PR: [https://github.com/apache/nifi-minifi-cpp/pull/1139] – I kept the simplest
version taking no arguments at all, as I don't think we really need to control
what the temporary files are called, as long as their names are unique.
was:There are at least two ways to create a temporary directory in tests
(method(s) in TestController and a helper in TestUtils.h). Moreover these
require a modifiable buffer which makes them cumbersome to use (we introduce a
single-use format variable most of the time). We should change all directory
creation to use a function taking 'const char*' or 'const char(&)[N]'
> Unify temporary directory creation in tests
> -------------------------------------------
>
> Key: MINIFICPP-1600
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1600
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Adam Debreceni
> Assignee: Ferenc Gerlits
> Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are at least two ways to create a temporary directory in tests
> (method(s) in TestController and a helper in TestUtils.h). Moreover these
> require a modifiable buffer which makes them cumbersome to use (we introduce
> a single-use format variable most of the time). We should change all
> directory creation to use a function taking 'const char*' or 'const
> char(&)[N]'
> PR: [https://github.com/apache/nifi-minifi-cpp/pull/1139] – I kept the
> simplest version taking no arguments at all, as I don't think we really need
> to control what the temporary files are called, as long as their names are
> unique.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
