fgerlits commented on a change in pull request #1139:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1139#discussion_r676536348
##########
File path: encrypt-config/tests/CMakeLists.txt
##########
@@ -32,7 +32,7 @@ foreach(testfile ${ENCRYPT_CONFIG_TESTS})
target_include_directories(${testfilename} BEFORE PRIVATE
"${CMAKE_SOURCE_DIR}/libminifi/test")
target_wholearchive_library(${testfilename} minifi)
- target_link_libraries(${testfilename} ${CATCH_MAIN_LIB})
+ target_link_libraries(${testfilename} ${CATCH_MAIN_LIB} ${TEST_BASE_LIB})
Review comment:
It's needed because `encrypt-config/tests/ConfigFileTests.cpp` now uses
`TestController`, which is in `test_base` (= `${TEST_BASE_LIB}`. Before this
change, `ConfigFileTests` created the temporary directory directly using
`utils::file::create_temp_directory()` -- which also means that this test
directory was not cleaned up after the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
