fgerlits commented on a change in pull request #1139:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1139#discussion_r676740661
##########
File path: extensions/sftp/tests/FetchSFTPTests.cpp
##########
@@ -74,18 +72,15 @@ class FetchSFTPTestsFixture {
LogTestController::getInstance().setDebug<processors::LogAttribute>();
LogTestController::getInstance().setDebug<SFTPTestServer>();
- // Create temporary directories
- testController.createTempDirectory(src_dir);
- REQUIRE(src_dir != nullptr);
- testController.createTempDirectory(dst_dir);
- REQUIRE(dst_dir != nullptr);
+ REQUIRE_FALSE(src_dir.empty());
+ REQUIRE_FALSE(dst_dir.empty());
+ REQUIRE(plan);
Review comment:
To make sure that the pointer is not null, since we dereference it
later. An assertion failure here is better than a segmentation fault later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
