martinzink commented on a change in pull request #1116: URL: https://github.com/apache/nifi-minifi-cpp/pull/1116#discussion_r677487055
########## File path: libminifi/include/utils/NetworkInterfaceInfo.h ########## @@ -0,0 +1,75 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <string> +#include <vector> +#include <memory> +#include <unordered_map> +#include <optional> +#include "core/logging/Logger.h" + +#ifdef WIN32 +struct _IP_ADAPTER_ADDRESSES_LH; +typedef _IP_ADAPTER_ADDRESSES_LH IP_ADAPTER_ADDRESSES_LH; +typedef IP_ADAPTER_ADDRESSES_LH IP_ADAPTER_ADDRESSES; +#else +struct ifaddrs; +#endif + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { + +namespace utils { +class NetworkInterfaceInfo { + public: + NetworkInterfaceInfo(NetworkInterfaceInfo&& src) noexcept = default; +#ifdef WIN32 + explicit NetworkInterfaceInfo(const IP_ADAPTER_ADDRESSES* adapter); +#else + explicit NetworkInterfaceInfo(const struct ifaddrs* ifa); +#endif + NetworkInterfaceInfo& operator=(NetworkInterfaceInfo&& other) noexcept = default; + const std::string& getName() const noexcept { return name_; } + bool hasIpV4Address() const noexcept { return ip_v4_addresses_.size() > 0; } + bool hasIpV6Address() const noexcept { return ip_v6_addresses_.size() > 0; } + bool isRunning() const noexcept { return running_; } + bool isLoopback() const noexcept { return loopback_; } + const std::vector<std::string>& getIpV4Addresses() const noexcept { return ip_v4_addresses_; } + const std::vector<std::string>& getIpV6Addresses() const noexcept { return ip_v6_addresses_; } + + void moveAddressesInto(NetworkInterfaceInfo& destination); Review comment: you are right, moved it to private -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
