jfrazee commented on a change in pull request #5098:
URL: https://github.com/apache/nifi/pull/5098#discussion_r677512004



##########
File path: 
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/ListAzureDataLakeStorage.java
##########
@@ -226,9 +239,12 @@ protected String getPath(ProcessContext context) {
             options.setRecursive(recurseSubdirectories);
 
             Pattern baseDirectoryPattern = Pattern.compile("^" + baseDirectory 
+ "/?");
+            final String tempFilePrefix = 
defaultIfBlank(System.getProperty("tempFilePrefix"), TEMP_FILE_PREFIX);

Review comment:
       The renaming should still be atomic.
   
   Are you asking if we should support a temporary name prefix and a temporary 
directory? I'd go with one or another and not both. I prefer a location because 
in a high volume ingest scenario there could be a lot of temporary files.
   
   I'd have to look closer at PutHDFS. I don't think that's ideal behavior 
though if there's a possibility of multiple writers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to