kotarot commented on a change in pull request #4943:
URL: https://github.com/apache/nifi/pull/4943#discussion_r678170997



##########
File path: nifi-toolkit/nifi-toolkit-assembly/pom.xml
##########
@@ -308,5 +308,135 @@ language governing permissions and limitations under the 
License. -->
                 </plugins>
             </build>
         </profile>
+        <profile>
+            <id>rpm</id>
+            <activation>
+                <activeByDefault>false</activeByDefault>
+            </activation>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-dependency-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>unpack-shared-resources</id>
+                                <goals>
+                                    <goal>unpack-dependencies</goal>
+                                </goals>
+                                <phase>generate-resources</phase>
+                                <configuration>
+                                    
<outputDirectory>${project.build.directory}/generated-resources</outputDirectory>
+                                    
<includeArtifactIds>nifi-resources</includeArtifactIds>
+                                    
<includeGroupIds>org.apache.nifi</includeGroupIds>
+                                    
<excludeTransitive>false</excludeTransitive>
+                                </configuration>
+                            </execution>
+                            <execution>
+                                <id>unpack-docs</id>
+                                <goals>
+                                    <goal>unpack-dependencies</goal>
+                                </goals>
+                                <phase>generate-resources</phase>
+                                <configuration>
+                                    
<outputDirectory>${project.build.directory}/generated-docs</outputDirectory>
+                                    
<includeArtifactIds>nifi-docs</includeArtifactIds>
+                                    
<includeGroupIds>org.apache.nifi</includeGroupIds>
+                                    
<excludeTransitive>false</excludeTransitive>
+                                    <excludes>LICENSE,NOTICE</excludes>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                    <plugin>
+                        <groupId>org.codehaus.mojo</groupId>
+                        <artifactId>rpm-maven-plugin</artifactId>
+                        <configuration>
+                            <name>nifi-toolkit</name>
+                            <summary>Apache NiFi Toolkit</summary>
+                            <description>Apache NiFi Toolkit</description>
+                            <license>Apache License, Version 2.0 and others 
(see included LICENSE file)</license>
+                            <url>http://nifi.apache.org</url>

Review comment:
       My suggestion:
   ```suggestion
                               
<url>https://nifi.apache.org/docs/nifi-docs/html/toolkit-guide.html</url>
   ```
   
   like 
[nifi-registry](https://github.com/apache/nifi/blob/2daac5714a6050dd872522ff74d7fe71f700db6e/nifi-registry/nifi-registry-assembly/pom.xml#L285).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to