szaszm commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r680915970



##########
File path: libminifi/test/unit/MemoryUsageTest.cpp
##########
@@ -16,6 +16,9 @@
  * limitations under the License.
  */
 
+// including the extensions messes up the memory usage
+#define EXTENSION_LIST ""

Review comment:
       It seems to be 30M, but I guess we just go over that memory usage with 
everything loaded.
   
   Could you maybe update the comment to something along the lines of "Loading 
the extensions increases the memory usage, potentially going over the threshold 
that this test expects"? Or double the size to increase this threshold.
   
   Maybe @martinzink can also comment on this issue, but I suspect there's not 
much more to add.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to