sushilkm commented on pull request #4863: URL: https://github.com/apache/nifi/pull/4863#issuecomment-891438441
> Hey @sushilkm, thanks for this. I've gone through all the code. > > * I think the changes for the Cosmos DB CS are good. > * I made some style suggestions around descriptions for the various property descriptors. In most cases it's to make the description a noun and to shorten things up. > * The current formatting is pretty aggressive on line lengths so I suggested some changes. It's ok to go over 80 but needs to be less than 200 to pass the checkstyle. I'd say you're ok not breaking lines until you're around 110 or 120 or so. > * I do have a question about why these are `*SecureCredentialsControllerService` and not `*KeyVaultCredentialsControllerService`. Is there an intended difference? Thank you @jfrazee for reviewing this. As suggested I have made changes in the PR. - Regarding the checkstyle thing, the tests works fine so I was not sure how should I further work on finding the issues. - I have updated the name from `*SecureCredentialsControllerService` to `*KeyVaultCredentialsControllerService`, because it made sense and there was no intended difference for the name. Please have a look at this again. Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
