adamdebreceni commented on a change in pull request #1143:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1143#discussion_r681489147



##########
File path: libminifi/src/core/yaml/YamlConfiguration.cpp
##########
@@ -764,8 +764,15 @@ void YamlConfiguration::parseSingleProperty(const 
std::string& propertyName, con
   core::Property myProp(propertyName, "", "");
   processor->getProperty(propertyName, myProp);
   const PropertyValue coercedValue = 
getValidatedProcessorPropertyForDefaultTypeInfo(myProp, propertyValueNode);

Review comment:
       what about this `getValidatedProcessorPropertyForDefaultTypeInfo` 
function? it seems to log errors on exception, in which case does it not log, 
when it should?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to