lordgamez commented on a change in pull request #1132:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1132#discussion_r681535518



##########
File path: 
docker/test/integration/minifi/flow_serialization/Minifi_flow_yaml_serializer.py
##########
@@ -92,21 +108,22 @@ def serialize(self, connectable, root=None, visited=None):
                     res['Connections'].append({
                         'name': str(uuid.uuid4()),
                         'source id': str(connectable.uuid),
-                        'source relationship name': conn_name,
                         'destination id': str(proc.uuid),
                         'drop empty': ("true" if proc.drop_empty_flowfiles 
else "false")
                     })
+                    if (str(connectable.uuid) not in [x['id'] for x in 
res['Funnels']]):
+                        res['Connections'][-1]['source relationship name'] = 
conn_name
                     if proc not in visited:
-                        self.serialize(proc, res, visited)
+                        self.serialize_node(proc, res, visited)
             else:
                 res['Connections'].append({
                     'name': str(uuid.uuid4()),
                     'source id': str(connectable.uuid),
-                    'source relationship name': conn_name,
                     'destination id': str(conn_procs.uuid)
                 })
+                if (str(connectable.uuid) not in [x['id'] for x in 
res['Funnels']]):

Review comment:
       Yeah, I like this better :) Updated in 
f6a40ef8ad7c2e10b048100e8279dfb00a95c14d




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to