exceptionfactory commented on a change in pull request #5259:
URL: https://github.com/apache/nifi/pull/5259#discussion_r682090858



##########
File path: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/main/java/org/apache/nifi/dbcp/hive/HiveConnectionPool.java
##########
@@ -426,4 +445,13 @@ public String getConnectionURL() {
     boolean isAllowExplicitKeytab() {
         return Boolean.parseBoolean(System.getenv(ALLOW_EXPLICIT_KEYTAB));
     }
+
+    private long extractMillisWithInfinite(PropertyValue prop) {
+        if (prop.getValue() == null || "-1".equals(prop.getValue())) {

Review comment:
       Minor adjustment to reuse the static default:
   ```suggestion
           if (prop.getValue() == null || 
DEFAULT_MAX_CONN_LIFETIME.equals(prop.getValue())) {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to