adam-markovics commented on a change in pull request #1149:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1149#discussion_r682377404
##########
File path: cmake/BundledPahoMqttC.cmake
##########
@@ -45,7 +45,7 @@ function(use_bundled_pahomqttc SOURCE_DIR BINARY_DIR)
ExternalProject_Add(
paho.mqtt.c-external
GIT_REPOSITORY "https://github.com/eclipse/paho.mqtt.c.git";
- GIT_TAG "6aa07f575bc9369402b1b252fd280373f8d585ef" # This is not a
tagged/released version, but the exact one that was in our repo.
+ GIT_TAG "3b7ae6348bc917d42c04efa962e4868c09bbde9f" # Once tagged
as v1.3.9 release, but tags may move
Review comment:
They can move like this: delete tag (`git tag -d tagname`), put the same
tag somewhere else.
From Professional CMake by Craig Scott on ExternalProject_Add (chapter
27.1.1):
"While GIT_TAG does support these different choices, it should be noted that
only a commit hash is truly unambiguous.
With git, the commit referenced by a branch or tag name can move over time,
so using them does not guarantee a repeatable build."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
