lordgamez commented on a change in pull request #1151:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1151#discussion_r682609297
##########
File path: docker/focal/Dockerfile
##########
@@ -29,19 +29,22 @@ ENV MINIFI_HOME
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/
RUN apt update
-RUN DEBIAN_FRONTEND="noninteractive" apt install -y openjdk-8-jdk
openjdk-8-source python3.9-dev sudo git maven autogen autoconf automake cmake
+RUN DEBIAN_FRONTEND="noninteractive" apt install -y openjdk-8-jdk
openjdk-8-source python3.9-dev sudo git maven autogen autoconf automake cmake
software-properties-common
RUN mkdir -p $MINIFI_BASE_DIR
Review comment:
Usually it's recommended to minimize the layer count and as every
command in a Dockerfile creates a new layer it is good practice to merge
multiple RUN commands to have less layers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
