fgerlits commented on a change in pull request #1157:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1157#discussion_r683444095
##########
File path: CMakeLists.txt
##########
@@ -96,6 +83,59 @@ set_property(CACHE STRICT_GSL_CHECKS PROPERTY STRINGS
${STRICT_GSL_CHECKS_Values
if (WIN32)
option(MSI_REDISTRIBUTE_UCRT_NONASL "Redistribute Universal C Runtime
DLLs with the MSI generated by CPack. The resulting MSI is not distributable
under Apache 2.0." OFF)
+ option(ENABLE_WEL "Enables the suite of Windows Event Log extensions."
OFF)
+ option(ENABLE_PDH "Enables PDH support." OFF)
+endif()
+
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+ option(ENABLE_SYSTEMD "Disables the systemd extension." ON)
Review comment:
the description should say "Enables ..."
##########
File path: CMakeLists.txt
##########
@@ -428,23 +460,17 @@ if (ENABLE_ALL OR ENABLE_COAP STREQUAL "ON")
endif()
endif()
-if (WIN32)
- option(ENABLE_WEL "Enables the suite of Windows Event Log extensions."
OFF)
- if (ENABLE_ALL OR ENABLE_WEL)
-
- include(BundledPugiXml)
- use_bundled_pugixml(${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR})
- createExtension(WEL-EXTENSION "WEL EXTENSIONS" "Enables the
suite of Windows Event Log extensions." "extensions/windows-event-log"
"extensions/windows-event-log/tests")
- endif()
-endif(WIN32)
+if (WIN32 AND (ENABLE_ALL OR ENABLE_WEL))
+ include(BundledPugiXml)
+ use_bundled_pugixml(${CMAKE_CURRENT_SOURCE_DIR}
${CMAKE_CURRENT_BINARY_DIR})
+ createExtension(WEL-EXTENSION "WEL EXTENSIONS" "Enables the suite of
Windows Event Log extensions." "extensions/windows-event-log"
"extensions/windows-event-log/tests")
+endif(WIN32 AND (ENABLE_ALL OR ENABLE_WEL))
Review comment:
I would change this to `endif()`
##########
File path: CMakeLists.txt
##########
@@ -96,6 +83,59 @@ set_property(CACHE STRICT_GSL_CHECKS PROPERTY STRINGS
${STRICT_GSL_CHECKS_Values
if (WIN32)
option(MSI_REDISTRIBUTE_UCRT_NONASL "Redistribute Universal C Runtime
DLLs with the MSI generated by CPack. The resulting MSI is not distributable
under Apache 2.0." OFF)
+ option(ENABLE_WEL "Enables the suite of Windows Event Log extensions."
OFF)
+ option(ENABLE_PDH "Enables PDH support." OFF)
+endif()
+
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
+ option(ENABLE_SYSTEMD "Disables the systemd extension." ON)
+endif()
+
+option(DISABLE_EXPRESSION_LANGUAGE "Disables the scripting extensions." OFF)
+option(DISABLE_CIVET "Disables CivetWeb components." OFF)
+option(DISABLE_ROCKSDB "Disables the RocksDB extension." OFF)
+option(DISABLE_LIBARCHIVE "Disables the lib archive extensions." OFF)
+option(DISABLE_LZMA "Disables the liblzma build" OFF)
+option(DISABLE_BZIP2 "Disables the bzip2 build" OFF)
+option(ENABLE_GPS "Enables the GPS extension." OFF)
+option(ENABLE_COAP "Enables the CoAP extension." OFF)
+option(ENABLE_SQL "Enables the SQL Suite of Tools." OFF)
+option(ENABLE_MQTT "Enables the mqtt extension." OFF)
+option(ENABLE_PCAP "Enables the PCAP extension." OFF)
+option(ENABLE_LIBRDKAFKA "Enables the librdkafka extension." OFF)
+option(DISABLE_SCRIPTING "Disables the scripting extensions." OFF)
+option(ENABLE_SENSORS "Enables the Sensors package." OFF)
+option(ENABLE_USB_CAMERA "Enables USB camera support." OFF)
+option(ENABLE_TENSORFLOW "Disables the TensorFlow extensions." OFF) ##
Disabled by default because TF can be complex/environment-specific to build
Review comment:
old typo, but should be "Enables ..."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
