exceptionfactory opened a new pull request #5298: URL: https://github.com/apache/nifi/pull/5298
#### Description of PR NIFI-9037 Simplifies the GitHub workflow configuration for automated builds using a combination of default variables and updated actions. Multiple arguments for various commands are now defined on separate lines with the [YAML Multiline Block Chomping](https://yaml-multiline.info/) indicator for improved readability. Updates include the following: - Created environment variables for shared Maven commands and projects - Combined multiple Maven Cache actions - Added System Information step with commands to print CPU and memory information for each platform - Added node_modules to NPM Cache action configuration - Disabled NiFi Registry integration tests in the default configuration - Removed JUnit Results artifacts from workflow - Removed parallel build argument from GitHub workflow Maven command - Upgraded Surefire Plugin to 3.0.0-M5 - Upgraded Enforcer Plugin to 3.0.0 - Added package-lock.json for nifi-jolt-transform-json-ui The Ubuntu and MacOS builds use the same parameters, while the Windows build does not include the `contrib-check` or `include-grpc` profiles. The Windows build includes an additional step to get the NPM cache directory, which is not necessary on Linux or MacOS. All builds use the same list of Maven projects, which exclude the `assembly` modules for each major component. Upgrading the Maven Surefire plugin to 3.0.0-M5 supports [TCP socket communication](https://issues.apache.org/jira/browse/SUREFIRE-1658) with forked runners, which avoids the following error observed in current actions: `Corrupted STDOUT by directly writing to native stream in forked JVM 1` With most GitHub runners having one available core, removing argument for multi-threading Maven builds did not have a noticeable impact on performance, but it eliminated warnings due to the Apache RAT plugin not indicating support for parallel execution. Removing the generation and storage of XML JUnit tests provide some amount of optimization over the entire job execution. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)? - [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [X] Have you verified that the full build is successful on JDK 8? - [X] Have you verified that the full build is successful on JDK 11? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
