[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1137: MINIFICPP-1607 Add AttributesToJson processor

Tue, 17 Aug 2021 00:23:32 -0700 


adamdebreceni commented on a change in pull request #1137:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1137#discussion_r690104835



##########
File path: libminifi/test/TestBase.h
##########
@@ -164,6 +165,31 @@ class LogTestController {
     return found;
   }
 
+  std::optional<std::smatch> matchesRegex(const std::string &regex_str,

Review comment:
       measured an unrelated test to see if this method makes any difference, 
fortunately the difference is negligible (~50ms) so I think we can keep it as is




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to