[ 
https://issues.apache.org/jira/browse/NIFI-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15589852#comment-15589852
 ] 

ASF GitHub Bot commented on NIFI-2919:
--------------------------------------

Github user alopresto commented on the issue:

    https://github.com/apache/nifi/pull/1147
  
    I made a couple small changes, but otherwise +1. Verified by creating a 
directory structure as below and verified the positive case succeeded with no 
error output; the two negative cases caused the expected bulletins and log 
messages to be generated. 
    
    ```
    hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
    🔓 73s @ 16:03:49 $ ll
    total 0
    drwxr-xr-x   5 alopresto  staff   170B Oct 19 16:03 ./
    drwxr-xr-x  56 alopresto  staff   1.9K Oct 19 16:01 ../
    drwxr-xr-x   2 alopresto  staff    68B Oct 19 16:03 regular/
    d-wx-wx-wx   2 alopresto  staff    68B Oct 19 16:01 unreadable/
    dr-xr-xr-x   2 alopresto  staff    68B Oct 19 16:01 unwritable/
    hw12203:/Users/alopresto/Workspace/scratch/pr1147 (master) alopresto
    🔓 2s @ 16:03:52 $
    ```
    
    * Fixed typos in error message ("redable" -> "readable")
    * Changed multiline comment to block comment
    * Removed unusued imports in test
    * Fixed variable names & directory in test as per @olegz 's request above


> NiFi GetFile processor silently refuses to work if write permission is not 
> given to the input directory
> -------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2919
>                 URL: https://issues.apache.org/jira/browse/NIFI-2919
>             Project: Apache NiFi
>          Issue Type: Improvement
>            Reporter: Oleg Zhurakousky
>            Assignee: Oleg Zhurakousky
>             Fix For: 1.1.0
>
>
> GetFile processor requires write permission to its input directory.
> For example, if nifi is started by a user named 'nifi' (which is the case in 
> Ambari environment), and if the input directory does not give write 
> permission to user 'nifi', the processor simply stop working without giving 
> warning or error messages. From the end user's perspective, it is confusing.
> I'd like to improve the user's experience by providing some check and 
> warning. It is similar to the check of the existence of the input directory. 
> If the input directory is not present, GetFile already gives error messages 
> to the user. The same check can be done for directory permission.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to