bbende commented on pull request #5322: URL: https://github.com/apache/nifi/pull/5322#issuecomment-904648248
@exceptionfactory thanks for reviewing, committed your suggestions and added another commit for some logging tweaks. For the provided dependencies, yes the general approach is that any service API from standard services should never be included in any NAR besides nifi-standard-services-api-nar, so the pom for nifi-nar-bundles marks them all as provided in a dependency management block to ensure other NARs don't accidentally include them... https://github.com/apache/nifi/blob/main/nifi-nar-bundles/pom.xml#L179-L257 Then the nifi-standard-service-api-nar overrides the scopes to compile to actually include them: https://github.com/apache/nifi/blob/main/nifi-nar-bundles/nifi-standard-services/nifi-standard-services-api-nar/pom.xml So I was just removing redundant "provided" scopes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
