tpalfy commented on pull request #5319: URL: https://github.com/apache/nifi/pull/5319#issuecomment-905480871
> @tpalfy what was the reason behind all but scrapping and redoing the existing controller service? @MikeThomsen For backward compatibility's sake I'll put back the previous interface and implementation. I'll follow the suggestion by @exceptionfactory and mark them deprecated however. My main issue with the previous solution is that it leaves too many responsibilities in the hands of the caller - i.e. the processor. This makes it harder to integrate as those processors need to take care of getting username, password, client id and client secret configurations themselves (not to mention validation) and pass that to the controller service. Yet the url is separated from the rest of the configuration and tied to the controller service. This is inconvenient from a user experience point of view as well because new/modified client configurations need to be amended across multiple components. I would be curious how the previous solution was tested in a real-life environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
