szaszm commented on a change in pull request #1121:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1121#discussion_r694982414
##########
File path: docker/test/integration/features/s3.feature
##########
@@ -115,12 +115,14 @@ Feature: Sending data from MiNiFi-C++ to an AWS server
Given a GenerateFlowFile processor with the "File Size" property set to "1
kB" in a "secondary" flow
And a FetchS3Object processor set up to communicate with the same s3 server
And a PutFile processor with the "Directory" property set to "/tmp/output"
+ And a LogAttribute processor
Review comment:
Is this an intentional change or a leftover from debugging?
##########
File path: docker/test/integration/minifi/core/PostgreSQLServerContainer.py
##########
@@ -0,0 +1,20 @@
+from .Container import Container
+
+
+class PostgreSQLServerContainer(Container):
+ def __init__(self, name, vols, network, image_store):
+ super().__init__(name, 'postgresql-server', vols, network, image_store)
+
+ def get_startup_finished_log_entry(self):
+ return "database system is ready to accept connections"
+
+ def deploy(self):
+ if not self.set_deployed():
+ return
+
+ self.docker_container = self.client.containers.run(
+ self.image_store.get_image(self.get_engine()),
+ detach=True,
+ name='postgresql-server',
+ network=self.network.name,
+ environment=["POSTGRES_PASSWORD=password"])
Review comment:
I wonder why do we not need a port forward here. Is the unix socket
interface somehow forwarded to the host, or how do tests use postgres?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
