[
https://issues.apache.org/jira/browse/NIFI-9084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17405327#comment-17405327
]
Nathan Gough commented on NIFI-9084:
------------------------------------
Thank you for taking the lead on this, I realize changing unit tests is not
glamorous work so this is great. While I appreciate you're trying to scope
these changes to reduce the size of individual PRs, this is a huge number of
tickets for changing some unit tests. 81 tickets and PRs for updating unit
tests is a little much, and remember that we've been trying to reduce the
number of PRs sitting around in Github to reduce some of the 'noise' there. I
think we can do these changes with one Jira issue and a few PRs against that
one issue. I would suggest doing a bulk change for all the tests to JUnit5 (eg
simple things like @AfterEach and the imports etc) and for any tests that
happen to no longer pass with simple fixes we should put those into a separate
sub-task/PR. Then we can submit a single PR for all the tests that do pass
(yes it will be very large but the changes should be relatively the same) and
then we can address test changes that are not compatible with JUnit5 or need
more significant change.
Alternatively if that approach is too difficult, we can still use a single
issue and create a table in this ticket of the modules being changed, and
update the status of the table against a much smaller number of PRs against
this ticket as they are created, for example:
||Module||PR Number||Status||
|nifi-standard-bundle|0001|Merged|
|nifi-standard-services-bundle|0001|Merged|
|nifi-websock-bundle|0001|Merged|
|nifi-framework-bundle|0002|Open|
Let me know what you think.
> Refactor unit and integration tests to use JUnit 5 instead of JUnit 4
> ---------------------------------------------------------------------
>
> Key: NIFI-9084
> URL: https://issues.apache.org/jira/browse/NIFI-9084
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mike Thomsen
> Priority: Major
>
> This is the parent ticket to track all of this work. Everyone is welcome to
> attach a sub-task and take on a chunk of the work. Tickets for specific
> modules should be attached to this one and should only cover a handful of
> related modules to ensure that the work is scoped in a sane manner from the
> perspective of potential reviewers.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
