Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/583
Hey @jvwing, this is really nice. Just a couple general comments...
I'm not sure we want to include all the System/Java version details in the
about dialog. The `AboutDTO` which had these items added will be available for
any user who has permissions to access the UI. I have concern allowing all
users who can access the UI to know the server's OS/architecture/version and
what vendor/version of Java is running. Including these items in the System
Diagnostics is good IMO as users need to be granted explicit permission for
viewing system level details.
Leaving the build details in the About Dialog is good IMO. I would suggest
that we use the `DateTimeAdapter` on the build timestamp field to be consistent
with other timestamps rendered throughout the UI. Since these only add a couple
rows, it may make sense to remove the toggle and make the dialog a little bit
taller.
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
