ChrisSamo632 commented on a change in pull request #5299:
URL: https://github.com/apache/nifi/pull/5299#discussion_r702279809
##########
File path:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/FetchElasticsearchHttp.java
##########
@@ -214,7 +214,7 @@ public void onTrigger(final ProcessContext context, final
ProcessSession session
logger.debug("Fetching {}/{}/{} from Elasticsearch", new
Object[]{index, docType, docId});
// read the url property from the context
- final String urlstr =
StringUtils.trimToEmpty(context.getProperty(ES_URL).evaluateAttributeExpressions().getValue());
+ final String urlstr = StringUtils.trimToEmpty(getESUrl());
Review comment:
The `getESUrl()` method calls `trim()` on the value being returned, so
do we really need `StringUtils.trimToEmpty` or `.trim()` calls in all the
individual processors (I'd imagine not)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
