fgerlits commented on a change in pull request #1121:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1121#discussion_r702680939



##########
File path: docker/test/integration/minifi/processors/FetchS3Object.py
##########
@@ -20,4 +20,4 @@ def __init__(self,
                 'Proxy Username': proxy_username,
                 'Proxy Password': proxy_password,
             },
-            auto_terminate=['success'])
+            auto_terminate=['failure'])

Review comment:
       I think we should keep `success`, too, as all the other S3 processors 
auto-terminate `success`, so this one behaving differently might surprise 
someone in the future.
   ```suggestion
               auto_terminate=['success', 'failure'])
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to