exceptionfactory commented on a change in pull request #5368:
URL: https://github.com/apache/nifi/pull/5368#discussion_r702905489
##########
File path:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/test/java/org/apache/nifi/provenance/ITestPersistentProvenanceRepository.java
##########
@@ -504,7 +485,6 @@ public void testIndexOnRolloverWithImmenseAttribute()
throws IOException {
@Test
public void testIndexOnRolloverAndSubsequentSearch() throws IOException,
InterruptedException, ParseException {
- assumeFalse(isWindowsEnvironment());
Review comment:
I considered adding the annotation, but since this is an integration
test, it is not run automatically. It looks like the test was originally a unit
test that was changed to an integration test for performance reasons. Since it
doesn't run automatically, and does not appear to have platform-specific
operations, it seems better to leave off the `DisabledOnOs` annotation, but I
can add it at the class level if you think it still makes sense to retain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
