gresockj commented on a change in pull request #5289:
URL: https://github.com/apache/nifi/pull/5289#discussion_r703034322



##########
File path: nifi-assembly/pom.xml
##########
@@ -760,6 +760,12 @@ language governing permissions and limitations under the 
License. -->
             <version>1.15.0-SNAPSHOT</version>
             <type>nar</type>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-hashicorp-vault-nar</artifactId>

Review comment:
       My thought was that this nar would also contain jars for a 
`hashicorp-vault-parameter-provider` and a 
`hashicorp-vault-controller-service`.  In light of that, I was considering this 
more analogous to the `nifi-aws-nar`.  What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to