ChrisSamo632 commented on pull request #5355: URL: https://github.com/apache/nifi/pull/5355#issuecomment-913807442
Could be because I was running on Windows 11 (preview), that may have confused the Assume. As I've only that version of Windows to build from (normally I build from ubuntu), I don't have any other way to test. I imagine the GitHub CI run could be leaving the artefact and noone notices because then things get thrown away? It was, however, a brand new clone of the repo and first run through of the tests (after initially building with -DskipTests) On Mon, 6 Sep 2021, 16:30 exceptionfactory, ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > nifi-nar-bundles/nifi-groovyx-bundle/nifi-groovyx-processors/src/test/java/org/apache/nifi/processors/groovyx/ExecuteGroovyScriptTest.java > <https://github.com/apache/nifi/pull/5355#discussion_r702976979>: > > > @@ -105,7 +105,7 @@ public static void setupBeforeClass() throws Exception { > Assume.assumeTrue("Test only runs on *nix", !SystemUtils.IS_OS_WINDOWS); > FileUtils.copyDirectory(new File("src/test/resources"), new File("target/test/resources")); > //prepare database connection > - System.setProperty("derby.stream.error.file", "target/derby.log"); > + System.setProperty("derby.stream.error.file", "target" + File.separator + "derby.log"); > > According to line 105, this test class does not run on Windows. Is there > some other possible cause of derby.log being created in the > nifi-groovyx-processors directory? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/nifi/pull/5355#pullrequestreview-747319931>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC4YQHUFVNXZ6VOKBARX2MTUATNA7ANCNFSM5DCUTLIQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
