lordgamez commented on a change in pull request #1166:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1166#discussion_r703273131
##########
File path:
extensions/standard-processors/tests/unit/YamlConnectionParserTest.cpp
##########
@@ -163,10 +163,10 @@ TEST_CASE("Connections components are parsed from yaml",
"[YamlConfiguration]")
"flowfile expiration: \n"
"drop empty: \n"});
YamlConnectionParser yaml_connection_parser(connection_node,
"test_node", parent_ptr, logger);
- CHECK_THROWS(yaml_connection_parser.getWorkQueueSizeFromYaml());
- CHECK_THROWS(yaml_connection_parser.getWorkQueueDataSizeFromYaml());
- CHECK_THROWS(yaml_connection_parser.getFlowFileExpirationFromYaml());
- CHECK_THROWS(yaml_connection_parser.getDropEmptyFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getWorkQueueSizeFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getWorkQueueDataSizeFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getFlowFileExpirationFromYaml());
+ REQUIRE(0 == yaml_connection_parser.getDropEmptyFromYaml());
Review comment:
I agree, updated in 3d60c2431ccbd6073868aba88924e94d16867b80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
