pgyori commented on pull request #5381: URL: https://github.com/apache/nifi/pull/5381#issuecomment-917133183
This is a draft pull request at the moment. There are a few things that are going to get refactored, some optimized. There are some TODOs that I still need to work on (e.g. the processor's property validation is missing). The documentation is far from being complete. However, the field removal logic can now be reviewed and tested. For anyone reviewing this: a way to understand this logic is to start with the easiest unit test (the unit tests get more complicated from top to bottom in the order they are present in the TestRemoveRecordField class), and debug its execution all the way. The unit tests cover many complex cases of record handling and going through them will explain why certain parts are implemented as they are. Feedback is highly appreciated. If you find examples that cover cases for which the field removal logic does not work properly, let me know! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
