fgerlits commented on a change in pull request #1165:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1165#discussion_r708193348
##########
File path: extensions/standard-processors/processors/RouteOnAttribute.h
##########
@@ -39,9 +39,8 @@ namespace processors {
class RouteOnAttribute : public core::Processor {
public:
- RouteOnAttribute(const std::string& name, const utils::Identifier& uuid =
{}) // NOLINT
- : core::Processor(name, uuid),
- logger_(logging::LoggerFactory<RouteOnAttribute>::getLogger()) {
+ explicit RouteOnAttribute(const std::string& name, const utils::Identifier&
uuid = {}) // NOLINT
Review comment:
is the NOLINT still needed?
##########
File path: libminifi/src/utils/crypto/EncryptionManager.cpp
##########
@@ -32,11 +32,7 @@ namespace minifi {
namespace utils {
namespace crypto {
-#ifdef WIN32
-constexpr const char* DEFAULT_NIFI_BOOTSTRAP_FILE = "\\conf\\bootstrap.conf";
Review comment:
Why did you change this? If we want to change it, should
DEFAULT_NIFI_PROPERTIES_FILE be changed similarly, too? Either way, I don't
think this change should be part of this pull request.
##########
File path: libminifi/include/utils/file/FileManager.h
##########
@@ -17,18 +17,10 @@
#ifndef LIBMINIFI_INCLUDE_UTILS_FILE_FILEMANAGER_H_
#define LIBMINIFI_INCLUDE_UTILS_FILE_FILEMANAGER_H_
+#include <filesystem>
Review comment:
I think these `std::filesystem`-related changes should be in a separate
pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
