lordgamez commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r708994802



##########
File path: thirdparty/aws-sdk-cpp/dll-export-injection.patch
##########
@@ -0,0 +1,52 @@
+diff -rupN aws-sdk-cpp-src/aws-cpp-sdk-core/CMakeLists.txt 
aws-sdk-cpp-src-patched/aws-cpp-sdk-core/CMakeLists.txt

Review comment:
       Yeah on second glance it should be explicit enough, it can be kept this 
way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to