lordgamez commented on a change in pull request #1158:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1158#discussion_r709161278



##########
File path: extensions/azure/processors/AzureStorageProcessor.h
##########
@@ -0,0 +1,51 @@
+/**
+ * @file AzureStorageProcessor.h
+ * AzureStorageProcessor class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <string>
+
+#include "core/Property.h"
+#include "core/Processor.h"
+#include "core/logging/Logger.h"
+#include "core/logging/LoggerConfiguration.h"
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+class AzureStorageProcessor : public core::Processor {

Review comment:
       I'm usually not a fan of using `Base` suffixes in inheritance, but in 
this case I think it's okay to avoid confusion. Updated in 
c8257e48b454819ecef4cc2f527f2457a5f81b89

##########
File path: extensions/azure/processors/AzureStorageProcessor.h
##########
@@ -0,0 +1,51 @@
+/**
+ * @file AzureStorageProcessor.h
+ * AzureStorageProcessor class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <string>
+
+#include "core/Property.h"
+#include "core/Processor.h"
+#include "core/logging/Logger.h"
+#include "core/logging/LoggerConfiguration.h"
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+class AzureStorageProcessor : public core::Processor {
+ public:
+  // Supported Properties
+  static const core::Property AzureStorageCredentialsService;
+
+  explicit AzureStorageProcessor(const std::string& name, const 
minifi::utils::Identifier& uuid, const std::shared_ptr<logging::Logger>& logger)

Review comment:
       Updated in c8257e48b454819ecef4cc2f527f2457a5f81b89

##########
File path: extensions/azure/processors/PutAzureDataLakeStorage.h
##########
@@ -0,0 +1,106 @@
+/**
+ * @file PutAzureDataLakeStorage.h
+ * PutAzureDataLakeStorage class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <utility>
+#include <string>
+#include <memory>
+#include <optional>
+#include <vector>
+
+#include "core/Property.h"
+#include "core/logging/Logger.h"
+#include "core/logging/LoggerConfiguration.h"
+#include "storage/AzureDataLakeStorage.h"
+#include "utils/Enum.h"
+#include "AzureStorageProcessor.h"
+
+class PutAzureDataLakeStorageTestsFixture;
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+class PutAzureDataLakeStorage final : public AzureStorageProcessor {
+ public:
+  // Supported Properties
+  static const core::Property FilesystemName;
+  static const core::Property DirectoryName;
+  static const core::Property FileName;
+  static const core::Property ConflictResolutionStrategy;
+
+  // Supported Relationships
+  static const core::Relationship Failure;
+  static const core::Relationship Success;
+
+  SMART_ENUM(FileExistsResolutionStrategy,
+    (FAIL_FLOW, "fail"),
+    (REPLACE_FILE, "replace"),
+    (IGNORE_REQUEST, "ignore")
+  )
+
+  explicit PutAzureDataLakeStorage(const std::string& name, const 
minifi::utils::Identifier& uuid = minifi::utils::Identifier())
+    : PutAzureDataLakeStorage(name, uuid, nullptr) {
+  }
+
+  ~PutAzureDataLakeStorage() override = default;

Review comment:
       Updated in c8257e48b454819ecef4cc2f527f2457a5f81b89




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to