jfrazee commented on a change in pull request #5392:
URL: https://github.com/apache/nifi/pull/5392#discussion_r710362830
##########
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-client-service-api/src/main/java/org/apache/nifi/mongodb/MongoDBClientService.java
##########
@@ -31,10 +31,13 @@
public interface MongoDBClientService extends ControllerService {
String WRITE_CONCERN_ACKNOWLEDGED = "ACKNOWLEDGED";
String WRITE_CONCERN_UNACKNOWLEDGED = "UNACKNOWLEDGED";
- String WRITE_CONCERN_FSYNCED = "FSYNCED";
+ String WRITE_CONCERN_FSYNCED = "FSYNCED (Deprecated)";
Review comment:
I think changing the string of the write concerns will create an
upgrade incompatibility. If we want to communicate the deprecation of these we
can create an `AllowableValue` object for these with a description of the
deprecation and a note about the replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
