[
https://issues.apache.org/jira/browse/MINIFICPP-1626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Zink updated MINIFICPP-1626:
-----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
https://github.com/apache/nifi-minifi-cpp/commit/eaedb80cbd5b3884094e22ebe9dc8a1b1dc5d855
> Upgrade PCAP++ to a more recent release
> ---------------------------------------
>
> Key: MINIFICPP-1626
> URL: https://issues.apache.org/jira/browse/MINIFICPP-1626
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Martin Zink
> Assignee: Martin Zink
> Priority: Minor
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> The bundled PCAP++ is quite old, and although the CI passes, it has some
> deprecated C++17 features in it, which have been resolved since in PCAP++
> upstream. (it fails to compile on my machine)
> [https://github.com/seladb/PcapPlusPlus/commit/971bc9b93a2190b0ebf8213243189d51481174f2]
> There has been some patches applied to the bundled version.
> https://issues.apache.org/jira/browse/MINIFICPP-1492 <- solved in upstream
> [https://github.com/apache/nifi-minifi-cpp/commit/0a85355f8208f7cabd81e5fee9a72075289a1b28#diff-d5fb6148c112e5a8e71e9461291971936c683b6217ecc35b2af427dfd68edf68R94-R95]
> <- not sure if we really need this
>
> I think we should move to a more recent release to solve this issues.
> And possible use FetchContent instead of bundling the pcap with our source
> code
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
