adamdebreceni commented on a change in pull request #1170:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1170#discussion_r716532658
##########
File path: libminifi/include/utils/StringUtils.h
##########
@@ -75,7 +75,12 @@ class StringUtils {
static std::string toLower(std::string_view str);
- // Trim String utils
+ /**
+ * Strips the line ending (\n or \r\n) from the end of the input line.
+ * @param input_line
+ * @return (stripped line, line ending) pair
+ */
+ static std::pair<std::string, std::string> chomp(const std::string&
input_line);
Review comment:
we seem to migrate our StringUtils to operate on `std::string_view`
wherever possible, we might benefit from writing the new ones on the same note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
