markap14 commented on pull request #5412: URL: https://github.com/apache/nifi/pull/5412#issuecomment-929358954
@gresockj @exceptionfactory huge thanks for all of the very thoughtful and thorough feedback! I will push a new commit momentarily that should address all concerns. And I definitely agree @exceptionfactory that there are a lot more things that should be unit tested. I intended to write a bunch more tests and then it totally slipped my mind. So the next commit will include new tests, mostly around error conditions, such as timeouts, processors that throw exceptions, failure ports, etc. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
