exceptionfactory commented on a change in pull request #5409:
URL: https://github.com/apache/nifi/pull/5409#discussion_r718052046
##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/pom.xml
##########
@@ -78,6 +78,11 @@
<version>1.15.0-SNAPSHOT</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.ben-manes.caffeine</groupId>
+ <artifactId>caffeine</artifactId>
+ <version>2.8.1</version>
Review comment:
The latest version is `3.0.4`, can you use the latest version?
##########
File path:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/PutHDFS.java
##########
@@ -228,6 +240,14 @@ protected void preProcessConfiguration(final Configuration
config, final Process
FsPermission.setUMask(config, new FsPermission(dfsUmask));
}
+ @OnScheduled
+ public void onScheduled(final ProcessContext context) {
Review comment:
Should there a corresponding `onStopped` method that clears the
`aclCache`?
##########
File path: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/pom.xml
##########
@@ -78,6 +78,11 @@
<version>1.15.0-SNAPSHOT</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>com.github.ben-manes.caffeine</groupId>
+ <artifactId>caffeine</artifactId>
+ <version>2.8.1</version>
Review comment:
Thanks for pointing that out @greyp9. In that case, what about version
`2.9.2`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
