lordgamez commented on a change in pull request #1178:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1178#discussion_r719334534



##########
File path: extensions/azure/processors/PutAzureDataLakeStorage.cpp
##########
@@ -72,19 +72,26 @@ void PutAzureDataLakeStorage::initialize() {
 }
 
 void PutAzureDataLakeStorage::onSchedule(const 
std::shared_ptr<core::ProcessContext>& context, const 
std::shared_ptr<core::ProcessSessionFactory>& /*sessionFactory*/) {
-  connection_string_ = getConnectionStringFromControllerService(context);
-  if (connection_string_.empty()) {
+  auto credentials = getCredentialsFromControllerService(context);
+  if (!credentials) {
     throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Azure Storage Credentials 
Service property missing or invalid");
   }
 
+  if ((!credentials->getUseManagedIdentityCredentials() && 
credentials->buildConnectionString().empty()) ||
+      (credentials->getUseManagedIdentityCredentials() && 
credentials->getStorageAccountName().empty())) {
+    throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Azure Storage Credentials 
Service properties are not set or invalid");
+  }
+
+  credentials_ = *credentials;

Review comment:
       Same as before.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to