exceptionfactory commented on a change in pull request #5424:
URL: https://github.com/apache/nifi/pull/5424#discussion_r720338247
##########
File path:
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/flow/StandardStatelessDataflowFactory.java
##########
@@ -167,7 +163,9 @@ private synchronized PropertyEncryptor getEncryptor() {
return created;
}
- created =
getPropertyEncryptor(engineConfiguration.getSensitivePropsKey());
+ created = new
PropertyEncryptorBuilder(engineConfiguration.getSensitivePropsKey())
Review comment:
That's a good question.
I raised a similar question on the initial implementation PR, and at the
time, the goal was to keep Stateless as simple as possible. Given that the
previous default value in `nifi.properties` remained unchanged for many
releases, making this configurable does not seem to provide a great deal of
value.
In the future, it may also make sense to deprecate and remove the ability to
configure this in `nifi.properties`, and instead prefer a sensible default
value. This could be addressed in a separate issue if there are other reasons
to make it configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
