markap14 commented on a change in pull request #4952:
URL: https://github.com/apache/nifi/pull/4952#discussion_r721564377
##########
File path: nifi-api/src/main/java/org/apache/nifi/logging/ComponentLog.java
##########
@@ -102,11 +117,128 @@
void debug(String msg);
- void log(LogLevel level, String msg, Throwable t);
-
- void log(LogLevel level, String msg, Object... os);
-
- void log(LogLevel level, String msg);
-
- void log(LogLevel level, String msg, Object[] os, Throwable t);
+ default void debug(LogMessage logMessage) {
+ logWithLogMessage(LogLevel.ERROR, logMessage);
+ }
+
+ default void log(LogLevel level, String msg, Throwable t) {
+ switch (level) {
+ case DEBUG:
+ debug(msg, t);
+ break;
+ case ERROR:
+ case FATAL:
+ error(msg, t);
+ break;
+ case INFO:
+ info(msg, t);
+ break;
+ case TRACE:
+ trace(msg, t);
+ break;
+ case WARN:
+ warn(msg, t);
+ break;
+ }
+ }
+
+ default void log(LogLevel level, String msg, Object... os) {
+ switch (level) {
+ case DEBUG:
+ debug(msg, os);
+ break;
+ case ERROR:
+ case FATAL:
+ error(msg, os);
+ break;
+ case INFO:
+ info(msg, os);
+ break;
+ case TRACE:
+ trace(msg, os);
+ break;
+ case WARN:
+ warn(msg, os);
+ break;
+ }
+ }
+
+ default void log(LogLevel level, String msg) {
+ switch (level) {
+ case DEBUG:
+ debug(msg);
+ break;
+ case ERROR:
+ case FATAL:
+ error(msg);
+ break;
+ case INFO:
+ info(msg);
+ break;
+ case TRACE:
+ trace(msg);
+ break;
+ case WARN:
+ warn(msg);
+ break;
+ }
+ }
+
+ default void log(LogLevel level, String msg, Object[] os, Throwable t) {
+ switch (level) {
+ case DEBUG:
+ debug(msg, os, t);
+ break;
+ case ERROR:
+ case FATAL:
+ error(msg, os, t);
+ break;
+ case INFO:
+ info(msg, os, t);
+ break;
+ case TRACE:
+ trace(msg, os, t);
+ break;
+ case WARN:
+ warn(msg, os, t);
+ break;
+ }
+ }
+
+ default void log(LogMessage message) {
+ switch (message.getLogLevel()) {
+ case DEBUG:
+ debug(message);
+ break;
+ case ERROR:
+ case FATAL:
+ error(message);
+ break;
+ case INFO:
+ info(message);
+ break;
+ case TRACE:
+ trace(message);
+ break;
+ case WARN:
+ warn(message);
+ break;
+ }
+ }
+
+ default void logWithLogMessage(LogLevel level, LogMessage logMessage) {
Review comment:
This should probably just be called `log`, rather than
`logWithLogMessage`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
