fgerlits commented on a change in pull request #1192:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1192#discussion_r721980831
##########
File path: extensions/http-curl/tests/C2LogHeartbeatTest.cpp
##########
@@ -17,14 +17,18 @@
*/
#undef NDEBUG
+
#include "TestBase.h"
+
#include "c2/C2Agent.h"
+#include "c2/HeartbeatLogger.h"
#include "protocols/RESTProtocol.h"
#include "protocols/RESTSender.h"
#include "HTTPIntegrationBase.h"
#include "HTTPHandlers.h"
+#include "range/v3/all.hpp"
Review comment:
Yeah, 0.6s (times many files, as I expect we'll use it all over the
place) off the compilation time is a good thing. I've changed the includes in
https://github.com/apache/nifi-minifi-cpp/pull/1192/commits/1888957191f4a103acf51acae767aa89679e9cc6.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
