[
https://issues.apache.org/jira/browse/NIFI-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15597806#comment-15597806
]
ASF GitHub Bot commented on NIFI-1531:
--------------------------------------
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1154
NIFI-1531 - Remove bogus .gitignore files from sub directories
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [-] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [-] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [-] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi NIFI-1531
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1154
----
commit 102c86ede557b344fab511b46fcfecb067a36811
Author: Andre F de Miranda <[email protected]>
Date: 2016-10-22T12:47:23Z
NIFI-1531 - Remove bogus .gitignore files from sub directories
----
> fix .gitignores throughout codebase
> -----------------------------------
>
> Key: NIFI-1531
> URL: https://issues.apache.org/jira/browse/NIFI-1531
> Project: Apache NiFi
> Issue Type: Task
> Components: Tools and Build
> Reporter: Tony Kurc
> Assignee: Andre
>
> There are some unnecessary and incorrect
> (https://github.com/apache/nifi/blob/master/nifi-commons/nifi-properties/.gitignore)
> .gitignore files. These should be cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
