adamdebreceni commented on a change in pull request #1188:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1188#discussion_r730645534
##########
File path: cmake/BuildTests.cmake
##########
@@ -70,7 +70,8 @@ function(createTests testName)
if (Boost_FOUND)
target_include_directories(${testName} BEFORE PRIVATE
"${Boost_INCLUDE_DIRS}")
endif()
- target_link_libraries(${testName} ${CMAKE_DL_LIBS} ${TEST_BASE_LIB})
+ target_link_libraries(${testName} ${CMAKE_DL_LIBS})
+ target_wholearchive_library(${testName} ${TEST_BASE_LIB})
Review comment:
if we want to dynamically instantiate (by name, through ClassLoader)
test-only processors (e.g. here the `ReadFromFlowFileTestProcessor`)
unfortunately we need to wholearchive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
