markap14 commented on a change in pull request #5452:
URL: https://github.com/apache/nifi/pull/5452#discussion_r730931233
##########
File path:
nifi-toolkit/nifi-toolkit-cli/src/main/java/org/apache/nifi/toolkit/cli/impl/client/nifi/ControllerServicesClient.java
##########
@@ -43,10 +43,10 @@
ControllerServiceReferencingComponentsEntity
updateControllerServiceReferences(UpdateControllerServiceReferenceRequestEntity
referencesEntity) throws NiFiClientException, IOException;
- VerifyControllerServiceConfigRequestEntity
submitConfigVerificationRequest(VerifyControllerServiceConfigRequestEntity
configRequestEntity) throws NiFiClientException, IOException;
+ VerifyConfigRequestEntity
submitConfigVerificationRequest(VerifyConfigRequestEntity configRequestEntity)
throws NiFiClientException, IOException;
- VerifyControllerServiceConfigRequestEntity
getConfigVerificationRequest(String serviceId, String verificationRequestId)
throws NiFiClientException, IOException;
+ VerifyConfigRequestEntity getConfigVerificationRequest(String serviceId,
String verificationRequestId) throws NiFiClientException, IOException;
- VerifyControllerServiceConfigRequestEntity
deleteConfigVerificationRequest(String serviceId, String verificationRequestId)
throws NiFiClientException, IOException;
+ VerifyConfigRequestEntity deleteConfigVerificationRequest(String
serviceId, String verificationRequestId) throws NiFiClientException,
IOException;
Review comment:
I think adding that in, along with system tests is definitely a good
idea. But I don't think we should block this PR in order to provide system
tests. And I'd recommend not implementing that in the client until we build the
system tests that can exercise & verify the behavior. It's not immediately
clear to me how this might be used from the client outside of the context of
system tests, so I'd recommend we implement it in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
