thenatog commented on a change in pull request #5398: URL: https://github.com/apache/nifi/pull/5398#discussion_r733014391
########## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/relp/frame/RELPFrameDecoderTest.java ########## @@ -0,0 +1,100 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.processors.standard.relp.frame; + +import io.netty.buffer.ByteBufOutputStream; +import io.netty.buffer.Unpooled; +import io.netty.channel.embedded.EmbeddedChannel; +import org.apache.nifi.logging.ComponentLog; +import org.apache.nifi.processors.standard.relp.event.RELPMessage; +import org.apache.nifi.util.MockComponentLog; +import org.junit.jupiter.api.Test; + +import java.io.IOException; +import java.io.OutputStream; +import java.nio.charset.Charset; +import java.nio.charset.StandardCharsets; +import java.util.ArrayList; +import java.util.List; + +import static org.junit.Assert.assertEquals; + +class RELPFrameDecoderTest { + + final ComponentLog logger = new MockComponentLog(this.getClass().getSimpleName(), this); + + public static final String OPEN_FRAME_DATA = "relp_version=0\nrelp_software=librelp,1.2.7,http://librelp.adiscon.com\ncommands=syslog";; + public static final String SYSLOG_FRAME_DATA = "this is a syslog message here"; + + static final RELPFrame OPEN_FRAME = new RELPFrame.Builder() + .txnr(1) + .command("open") + .dataLength(OPEN_FRAME_DATA.length()) + .data(OPEN_FRAME_DATA.getBytes(StandardCharsets.UTF_8)) + .build(); + + static final RELPFrame SYSLOG_FRAME = new RELPFrame.Builder() + .txnr(2) + .command("syslog") + .dataLength(SYSLOG_FRAME_DATA.length()) + .data(SYSLOG_FRAME_DATA.getBytes(StandardCharsets.UTF_8)) + .build(); + + static final RELPFrame CLOSE_FRAME = new RELPFrame.Builder() + .txnr(3) + .command("close") + .dataLength(0) + .data(new byte[0]) + .build(); + + @Test + void testDecodeRELPEvents() throws IOException { + final List<RELPFrame> frames = getFrames(5); + ByteBufOutputStream eventBytes = new ByteBufOutputStream(Unpooled.buffer()); + sendFrames(frames, eventBytes); + EmbeddedChannel channel = new EmbeddedChannel(new RELPFrameDecoder(logger, Charset.defaultCharset())); Review comment: Yeah I guess the choice of charset here doesn't specifically matter. I'll pick a static charset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
