markap14 commented on a change in pull request #5462:
URL: https://github.com/apache/nifi/pull/5462#discussion_r733058387
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
##########
@@ -4381,7 +4381,7 @@ public ProcessGroupFlowEntity getProcessGroupFlow(final
String groupId) {
// doesn't include that anyway. So we can avoid including the
information in the status that is returned.
final ProcessGroupStatus groupStatus =
controllerFacade.getProcessGroupStatus(groupId, 1);
final PermissionsDTO permissions =
dtoFactory.createPermissionsDto(processGroup);
- return
entityFactory.createProcessGroupFlowEntity(dtoFactory.createProcessGroupFlowDto(processGroup,
groupStatus, revisionManager, this::getProcessGroupBulletins), permissions);
+ return
entityFactory.createProcessGroupFlowEntity(dtoFactory.createProcessGroupFlowDto(processGroup,
groupStatus, revisionManager, this::getProcessGroupBulletins, uiOnly),
permissions);
Review comment:
I don't think it makes sense to introduce additional flexibility at this
point. We have essentially 2 modes - "everything" or "only what we need for the
UI". I don't expect to need any additional flexibility, to be honest. But if we
do, we can certainly introduce such a thing later. This isn't part of a public
API and so we can change it at will. Should avoid overcomplicating things to
accommodate for flexibility that we don't anticipate needing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
