GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/1156
NIFI-2909 and NIFI-1712 Per-Instance ClassLoading
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
## Summary of Changes
- Introduced a new annotation for processors, reporting tasks, controller
services - @RequiresInstanceClassLoading
- Added new builder method to PropertyDescriptor
dynamicallyModifiesClasspath(boolean)
- Created a new InstanceClassLoader that maintains a child-first internal
ClassLoader where classpath resources can be set, only used when component has
@RequiresInstanceClassLoading
- Added support to ExtensionManager to obtain ClassLoaders based on type +
id, before we only had by type
- If the type being requested supports instance class loading (the
annotation described above) it will create an InstanceClassLoader which starts
as a copy of the NAR ClassLoader for that type
- When properties are set on a component, the framework will identify the
properties that are classpath modifiers and add those resources to the
InstanceClassLoader's child resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-1712
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1156
----
commit 493a6097d3a44337ab08cfac9b6f8e24b350b2a6
Author: Bryan Bende <[email protected]>
Date: 2016-10-10T13:27:57Z
NIFI-2909 Adding per-instance class loading capability through
@RequiresInstanceClassLoading annotation
NIFI-1712 Applying per-instance class loading to HBaseClientService to
allow specifying Phoenix Client JAR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---