ottobackwards commented on a change in pull request #5458:
URL: https://github.com/apache/nifi/pull/5458#discussion_r735707010



##########
File path: 
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/StringUtils.java
##########
@@ -510,4 +514,20 @@ public static String toTitleCase(String input) {
                 .map(word -> Character.toTitleCase(word.charAt(0)) + 
word.substring(1))
                 .collect(Collectors.joining(" "));
     }
+

Review comment:
       string replace uses "old" , "new" semantics, maybe the parameter order 
should match that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to