[ 
https://issues.apache.org/jira/browse/NIFI-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603225#comment-15603225
 ] 

ASF GitHub Bot commented on NIFI-2937:
--------------------------------------

GitHub user brosander opened a pull request:

    https://github.com/apache/nifi/pull/1158

    NIFI-2937 - Adding configJsonIn option to tls-toolkit client and server

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [x] N/A - If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] N/A - If applicable, have you updated the LICENSE file, including the 
main LICENSE file under nifi-assembly?
    - [x] N/A - If applicable, have you updated the NOTICE file, including the 
main NOTICE file found under nifi-assembly?
    - [x] N/A - If adding new Properties, have you added .displayName in 
addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [x] N/A Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brosander/nifi NIFI-2937

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1158
    
----

----


> In TLS-Toolkit, allow users to specify separate input and output locations 
> for client configuration settings
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-2937
>                 URL: https://issues.apache.org/jira/browse/NIFI-2937
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Yolanda M. Davis
>            Assignee: Bryan Rosander
>
> Currently when using the tls-toolkit to generate client certificate artifacts 
> (keystore/truststore etc) users have the option to provide the location of a 
> configuration file that will provide the information necessary to create 
> those items (using the "F" argument).  Another option can be used to allow 
> toolkit to write out all of the settings generated back to the indicated 
> input file (using the "f" argument).  For scenarios where users may want to 
> pipe in input using stdin, vs referring to a file on disk, this is not 
> optimal since toolkit will attempt to write out to stdin causing an error.
> To prevent this error proposing to have the "f" argument also support an 
> output location, that is separate from the location provided with the "F" 
> argument.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to